Skip to content

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Apr 30, 2025

No description provided.

@Rom1-B Rom1-B force-pushed the feature/glpi-11.0 branch from b092404 to 3ff27f1 Compare April 30, 2025 11:56
@stonebuzz
Copy link
Contributor

can we add icon for alert_target.class.php

    public static function getIcon()
    {
        return 'ti ti-users';
    }

for icon tab

image

@Rom1-B Rom1-B self-assigned this May 21, 2025
@flegastelois
Copy link
Contributor

flegastelois commented May 26, 2025

  • beta1
  • url plugins/news/front/alert.form.php
  • error when trying to create a new alert
PHP User Warning (512): The macro "iconField" (./marketplace/news/templates/components/news_fields_macros.html.twig:65) uses an undeclared variable named "key". at TriggerErrorLogger.php line 53 in ./vendor/alisqi/twigqi/src/Logger/TriggerErrorLogger.php at line 53
Key "readonly" for sequence/mapping with keys "is_horizontal" does not exist.
In ./marketplace/news/templates/components/news_fields_macros.html.twig(42)
#0 ./files/_cache/11.0.0-dev-00000000-development/templates/0f/0f79dc7dd4085b517be46a17fedeaab6.php(102): Twig\Extension\CoreExtension::getAttribute()
#1 ./vendor/twig/twig/src/Extension/CoreExtension.php(2079): __TwigTemplate_1023feed5b9ce5753b293b4c05780d21->{closure}()
#2 ./files/_cache/11.0.0-dev-00000000-development/templates/0f/0f79dc7dd4085b517be46a17fedeaab6.php(74): Twig\Extension\CoreExtension::captureOutput()
#3 ./vendor/twig/twig/src/Extension/CoreExtension.php(2079): __TwigTemplate_1023feed5b9ce5753b293b4c05780d21->{closure}()
#4 ./files/_cache/11.0.0-dev-00000000-development/templates/0f/0f79dc7dd4085b517be46a17fedeaab6.php(68): Twig\Extension\CoreExtension::captureOutput()
#5 ./files/_cache/11.0.0-dev-00000000-development/templates/78/7880024e75bc3bf20b5018334c8efae9.php(116): __TwigTemplate_1023feed5b9ce5753b293b4c05780d21->macro_checkboxesField()
#6 ./vendor/twig/twig/src/Template.php(432): __TwigTemplate_461b4f39f03fc687c74aa570807938ef->block_form_fields()
#7 ./files/_cache/11.0.0-dev-00000000-development/templates/64/645a54b36b68242438060edbf6099abd.php(119): Twig\Template->yieldBlock()
#8 ./vendor/twig/twig/src/Template.php(388): __TwigTemplate_d81b21e91c0b92570cf7ea0a50796a27->doDisplay()
#9 ./files/_cache/11.0.0-dev-00000000-development/templates/78/7880024e75bc3bf20b5018334c8efae9.php(54): Twig\Template->yield()
#10 ./vendor/twig/twig/src/Template.php(388): __TwigTemplate_461b4f39f03fc687c74aa570807938ef->doDisplay()
#11 ./vendor/twig/twig/src/Template.php(344): Twig\Template->yield()
#12 ./vendor/twig/twig/src/TemplateWrapper.php(61): Twig\Template->display()
#13 ./src/Glpi/Application/View/TemplateRenderer.php(195): Twig\TemplateWrapper->display()
#14 ./marketplace/news/inc/alert.class.php(500): Glpi\Application\View\TemplateRenderer->display()
#15 ./src/CommonGLPI.php(666): PluginNewsAlert->showForm()
#16 ./ajax/common.tabs.php(109): CommonGLPI::displayStandardTab()
#17 ./src/Glpi/Controller/LegacyFileLoadController.php(59): require('...')
#18 ./vendor/symfony/http-kernel/HttpKernel.php(181): Glpi\Controller\LegacyFileLoadController->__invoke()
#19 ./vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#20 ./vendor/symfony/http-kernel/Kernel.php(197): Symfony\Component\HttpKernel\HttpKernel->handle()
#21 ./public/index.php(56): Symfony\Component\HttpKernel\Kernel->handle()
#22 {main}

image

@Rom1-B Rom1-B force-pushed the feature/glpi-11.0 branch from 9d630a5 to 748348e Compare May 27, 2025 07:54
@Rom1-B
Copy link
Contributor Author

Rom1-B commented May 27, 2025

@flegastelois,

Can you try with the last 2 commits, especially 748348e ?

@stonebuzz
Copy link
Contributor

need to check #180

@stonebuzz
Copy link
Contributor

@Rom1-B can you look at :

#180
#181

@Rom1-B Rom1-B force-pushed the feature/glpi-11.0 branch from d862529 to c905e36 Compare July 17, 2025 09:31
@Rom1-B Rom1-B requested a review from stonebuzz July 28, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants