Fix #5953: [java] PoC: Add rewrite support for errorprone.refasterrules

[Pankraz76]

Fix #5953: [java] PoC: Add rewrite support for errorprone.refasterrules

[Pankraz76]

Caused by: org.apache.maven.plugin.MojoExecutionException: Applying recipes would make changes. See logs for more details.

[Pankraz76]

Caused by: org.apache.maven.plugin.MojoExecutionException: Applying recipes would make changes. See logs for more details.

this quality gate will prevent any further @adangel @oowekyala

[zbynek]

Dead links detected

That's about documentation changes -- the link to gradle/plugins/common/src/main/kotlin/junitbuild.java-library-conventions.gradle.kts seems to be wrong.

[Pankraz76]

Thanks for suggestion. Seems ready to go then.

FYI on whats possible:
@bclozel
@iddeepak

refs:

• Add rewrite support for errorprone.refasterrules spring-projects/spring-framework#35270
• Use Collections#isEmpty or String#isEmpty spring-projects/spring-framework#35243
• PoC: Add rewrite support for errorprone.refasterrules apache/kafka#20219
• PoC: Add rewrite support for errorprone.refasterrules diffplug/spotless#2576
• Issue #17487: Add rewrite support for errorprone.refasterrules checkstyle/checkstyle#17490

[github-actions]

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 112 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-08-03 12:01:28+00:00 for b9ecb32)

[Pankraz76]

so is this something you would consider?

Error prone could help to avoid some bugs and automate some of checkstyle whitespaces stuff could simple follow.

[Pankraz76]

please see dedicated checkstyle approach:

• Issue #17487: Add rewrite support checkstyle/checkstyle#17545
• Issue #17487: Add openrewrite.maven.BestPractices checkstyle/checkstyle#17593
• Issue #17487: Add rewrite support for errorprone.refasterrules checkstyle/checkstyle#17490

We could also run the recipes without the plugin making the code fixes an increment for PMD. If the plugin then is worth to integrate could be determined afterwards.

@adangel
@oowekyala

If not we also close this as mentioned in on still ongoing and not resolved discussion:

• Improve Developer Experience #5875

I understand you dont want to integrate the plugin so fast, then encourage you to try other projects like maven to get in touch with spotless. Its the same idea behind all these tools so it should actually be simple here to argue for adding another static code analysis tool, or whats the big deal?