refactor: buildingBlocks to storeState #3105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/FLUDNYK4A |
See documentations for usage instructions.
dai-shi
approved these changes
Aug 28, 2025
|
@arjunvegda Please be aware that this is going to be a breaking change for you. |
2 tasks
|
This breaks jotai-effect due to the removal of cc @dmaskasky |
|
Yes, I have to update jotai-effect, and jotai-scope. I'll release this today. |
|
I just released [email protected], which now supports [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current building‑blocks implementation behaves unexpectedly when you try to derive one store from another. Each building‑block function closes over the arguments and default values supplied to the original
buildStorecall, so a derived store reuses those captured values instead of its own, causing unintended behavior.This PR refactors store internals to eliminate parent scope references.
API Changes
Changed
storeprop added to all atom interceptors and building block functionsatomOnInit(atom, store)->atomOnInit(store, atom)INTERNAL_buildStoreadded argssetAtomStateValueOrPromisestoreGetstoreSetstoreSubbuildingBlocksadded itemssetAtomStateValueOrPromisestoreGetstoreSetstoreSubtype BuildingBlocksnow mutableINTERNAL_getBuildingBlocksRev2returns typeReadonly<BuildingBlocks>Added
type INTERNAL_BuildingBlockstype INTERNAL_StoreHooksRemoved
INTERNAL_SetAtomStateValueOrPromiseCheck List
pnpm run fixfor formatting and linting code and docs