Better support for sharing in previews. #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jan 9, 2026
|
|
||
| struct CountersListView: View { | ||
| @FetchAll var counters: [Counter] | ||
| @FetchAll( |
Member
Author
There was a problem hiding this comment.
Updated the CloudKitDemo to show an icon next to counters that are shared. We can now explore that functionality in previews thanks to the changes in this PR.
mbrandonw
commented
Jan 9, 2026
| package let databaseScope: CKDatabase.Scope | ||
| let _container = IsolatedWeakVar<MockCloudContainer>() | ||
| let dataManager = Dependency(\.dataManager) | ||
| let deletedRecords = LockIsolated<[(CKRecord.ID, CKRecord.RecordType)]>([]) |
Member
Author
There was a problem hiding this comment.
We keep track of records deleted from the mock cloud database so that when fetching changes we can fetch deletions.
mbrandonw
commented
Jan 9, 2026
mbrandonw
commented
Jan 9, 2026
mbrandonw
commented
Jan 9, 2026
| syncEngine: syncEngine | ||
| ) | ||
| } else { | ||
| Form { |
Member
Author
There was a problem hiding this comment.
We now emulate a cloud sharing view in previews!
Member
Author
|
I scaled this PR back a bit since we went with a simpler model for emulating automatic sync in previews. |
stephencelis
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can emulate iCloud sharing in previews by making some updates to our mocks that power the sync engine.