-
Notifications
You must be signed in to change notification settings - Fork 76
Better support for sharing in previews. #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
105a55f
wip
stephencelis 3969174
wip
stephencelis 03a6ff3
wip
stephencelis bef7064
wip
stephencelis a6cc565
wip
stephencelis c8ce17d
Better support for sharing in previews.
mbrandonw c847dfd
wip
mbrandonw 2b2deaf
wip
mbrandonw f3c7375
wip
mbrandonw 3d15e5e
clean up
mbrandonw 3b686f1
wip
mbrandonw 7ae4728
clean up
mbrandonw 0066e5d
Trying out database pool for previews.
mbrandonw e673c67
wip
mbrandonw 82f0724
Merge remote-tracking branch 'origin/main' into better-preview-sharing
mbrandonw c04f60f
wip
mbrandonw 253d3ae
clean up
mbrandonw 044368f
clean up
mbrandonw 1165fb8
reformat
mbrandonw 9d49470
cancel timer when stopping sync engine
mbrandonw 8ed34cd
clean up
mbrandonw 8f556ee
wip
mbrandonw ca01d18
wip
mbrandonw eae64d1
wip
mbrandonw ba92711
clean up
mbrandonw 22b98c7
wip
mbrandonw 5df94bb
fixes
mbrandonw 090dd74
fix
mbrandonw 43727d5
wip
mbrandonw 6d5e42b
wip
mbrandonw 48b8f42
Revert "fix"
mbrandonw 89941f7
Revert "wip"
mbrandonw 84a476d
Revert "wip"
mbrandonw 87a7876
modernize previews
mbrandonw 4478fbf
wip
stephencelis 226b2ca
lock isolated
mbrandonw 175d3ca
wip
mbrandonw 8cacfbe
wiup
mbrandonw 2a81955
clean up
mbrandonw 640a8fa
Merge remote-tracking branch 'origin/main' into better-preview-sharing
mbrandonw 9a567a4
Fix merge conflicts.
mbrandonw 22d4400
Merge remote-tracking branch 'origin/main' into better-preview-sharing
stephencelis 5616370
wip
stephencelis 9a6a61e
format
stephencelis 8be0439
wip
mbrandonw 93d5124
wip
stephencelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
Examples/Examples.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the CloudKitDemo to show an icon next to counters that are shared. We can now explore that functionality in previews thanks to the changes in this PR.