Add traitCollection.push(state:)
#3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Feb 19, 2025
| /// - Parameter state: An element of stack state. | ||
| public func callAsFunction<Element: Hashable>(state: Element) { | ||
| @Dependency(\.stackElementID) var stackElementID | ||
| self(value: StackState.Component(id: stackElementID(), element: state)) |
Member
Author
There was a problem hiding this comment.
This reports an issue under the hood, so we should probably thread through the source context, but we need to make changes to Swift Navigation and cut a release to do that.
mdarnall
reviewed
Feb 19, 2025
mdarnall
left a comment
mdarnall
left a comment
There was a problem hiding this comment.
Thanks @stephencelis. This will be useful to properly drive a NavigationStackController from a Store with StackState
mbrandonw
approved these changes
Feb 19, 2025
mbrandonw
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UIKit equivalent of
NavigationLink(state:).