Skip to content

Add traitCollection.push(state:) #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Add traitCollection.push(state:) #3603

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e031cd
Add `traitCollection.push(state:)`
stephencelis Feb 19, 2025
c7f36fd
wip
stephencelis Feb 19, 2025
965310c
Merge remote-tracking branch 'origin/main' into uipushaction-state
stephencelis Feb 25, 2025
d075995
Fix
stephencelis Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/ComposableArchitecture/Documentation.docc/Extensions/UIKit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ integrate into application code written in UIKit.

### Presenting alerts and action sheets

- ``UIKit/UIAlertController/init(store:)``
- ``UIKit/UIAlertController``

### Stack-based navigation

- ``UIKitNavigation/NavigationStackController``
- ``UIKitNavigation/UIPushAction``

### Combine integration

Expand Down
16 changes: 15 additions & 1 deletion Sources/ComposableArchitecture/UIKit/NavigationStackControllerUIKit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import UIKit

extension NavigationStackController {

/// Drives a navigation stack controller with a store.
///
/// See the dedicated article on <doc:Navigation> for more information on the library's
Expand Down Expand Up @@ -69,4 +68,19 @@
}
}
}

@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
@MainActor
extension UIPushAction: Sendable {
/// Pushes an element of ``StackState`` onto the current navigation stack.
///
/// This is the UIKit equivalent of
/// ``SwiftUI/NavigationLink/init(state:label:fileID:filePath:line:column:)``.
///
/// - Parameter state: An element of stack state.
public func callAsFunction<Element: Hashable>(state: Element) {
@Dependency(\.stackElementID) var stackElementID
self(value: StackState.Component(id: stackElementID(), element: state))
Copy link
Member Author

@stephencelis stephencelis Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reports an issue under the hood, so we should probably thread through the source context, but we need to make changes to Swift Navigation and cut a release to do that.

}
}
#endif
Loading