Avoid extra MainActor hop from Shared[Reader].load(_:)#154
Merged
stephencelis merged 1 commit intopointfreeco:mainfrom May 7, 2025
Merged
Avoid extra MainActor hop from Shared[Reader].load(_:)#154stephencelis merged 1 commit intopointfreeco:mainfrom
Shared[Reader].load(_:)#154stephencelis merged 1 commit intopointfreeco:mainfrom
Conversation
stephencelis
approved these changes
May 7, 2025
Member
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
Thanks! I think this was here to solve an issue with SwiftUI observation, originally, but I think we have a more holistic solution employed these days, and so this looks good to us!
mhayes853
pushed a commit
to mhayes853/swift-sharing
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A drive-by observation while reading code, it doesn't seem necessary to hop to
MainActorin the body ofShared[Reader].load(_:).