Skip to content

Avoid extra MainActor hop from Shared[Reader].load(_:) #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencelis merged 1 commit into from
May 7, 2025
Merged

Avoid extra MainActor hop from Shared[Reader].load(_:) #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Sources/Sharing/SharedKey.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,15 @@ extension Shared {
/// - Parameter key: A shared key associated with the shared reference. It is responsible for
/// loading and saving the shared reference's value from some external source.
public func load(_ key: some SharedKey<Value>) async throws {
await MainActor.run {
@Dependency(PersistentReferences.self) var persistentReferences
SharedPublisherLocals.$isLoading.withValue(true) {
projectedValue = Shared(
reference: persistentReferences.value(
forKey: key,
default: wrappedValue,
skipInitialLoad: true
)
@Dependency(PersistentReferences.self) var persistentReferences
SharedPublisherLocals.$isLoading.withValue(true) {
projectedValue = Shared(
reference: persistentReferences.value(
forKey: key,
default: wrappedValue,
skipInitialLoad: true
)
}
)
}
try await load()
}
Expand Down
18 changes: 8 additions & 10 deletions Sources/Sharing/SharedReaderKey.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,17 +154,15 @@ extension SharedReader {
/// - Parameter key: A shared key associated with the shared reference. It is responsible for
/// loading the shared reference's value from some external source.
public func load(_ key: some SharedReaderKey<Value>) async throws {
await MainActor.run {
@Dependency(PersistentReferences.self) var persistentReferences
SharedPublisherLocals.$isLoading.withValue(true) {
projectedValue = SharedReader(
reference: persistentReferences.value(
forKey: key,
default: wrappedValue,
skipInitialLoad: true
)
@Dependency(PersistentReferences.self) var persistentReferences
SharedPublisherLocals.$isLoading.withValue(true) {
projectedValue = SharedReader(
reference: persistentReferences.value(
forKey: key,
default: wrappedValue,
skipInitialLoad: true
)
}
)
}
try await load()
}
Expand Down