Fix enum associated value decoding #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1447ea2.
We had a bug in enum decoding that resulted in the decoder missing a few columns along the way.
stephencelis
commented
Oct 29, 2025
| // if true { | ||
| if ProcessInfo.processInfo.environment["SPI_GENERATE_DOCS"] != nil { | ||
| if ProcessInfo.processInfo.environment["SPI_GENERATE_DOCS"] != nil | ||
| || ProcessInfo.processInfo.environment["CI"] != nil |
Member
Author
There was a problem hiding this comment.
Let's ensure enum tests are actually running in CI.
stephencelis
commented
Oct 29, 2025
Comment on lines
+2578
to
+2579
| let photo = try decoder.decode(Photo.self) | ||
| let note = try decoder.decode(String.self) |
Member
Author
There was a problem hiding this comment.
We need to call decoder.decode for every type so that the query decoder's cursor advances to the proper column offset.
stephencelis
commented
Oct 29, 2025
Comment on lines
392
to
-565
| fileprivate enum Kind { | ||
| case link(URL) | ||
| case note(String) | ||
| case notes(Attachment.Notes) | ||
| @Column(as: [String].JSONRepresentation.self) | ||
| case notesInline([String]) | ||
| case video(Attachment.Video) | ||
| case image(Attachment.Image) | ||
| } | ||
|
|
||
| @Selection fileprivate struct Notes { | ||
| @Column(as: [String].JSONRepresentation.self) | ||
| let list: [String] | ||
| } |
Member
Author
There was a problem hiding this comment.
@acosmicflamingo Sorry, I reverted these tests since they weren't actually running on CI and were actually failing with the changes I made.
I do wonder if this PR fixes some of the issues you were seeing, though!
Contributor
There was a problem hiding this comment.
No big deal! I'll have to see when I'm in front of a computer.
mbrandonw
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug in enum decoding that resulted in the decoder missing a few columns along the way.
Fixes #218.