Skip to content

Test on r-devel#1076

Open
lionel- wants to merge 2 commits intomainfrom
task/r-dev-tests
Open

Test on r-devel#1076
lionel- wants to merge 2 commits intomainfrom
task/r-dev-tests

Conversation

@lionel-
Copy link
Contributor

@lionel- lionel- commented Mar 2, 2026

Closes #1066

To track upstream breaking changes to critical components of our infrastructure:

Second commit fixes sensitivity of a test on HTML produced by R:

        FAIL [   0.834s] (296/861) ark lsp::help::tests::test_help_from_function
  stdout ───

    running 1 test
    test lsp::help::tests::test_help_from_function ... FAILED

    failures:

    failures:
        lsp::help::tests::test_help_from_function

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 490 filtered out; finished in 0.82s

  stderr ───

    thread 'lsp::help::tests::test_help_from_function' (22703) panicked at crates/ark/src/lsp/help.rs:384:38:
    called `Option::unwrap()` on a `None` value

@lionel- lionel- force-pushed the task/r-dev-tests branch 4 times, most recently from 761af84 to aea3008 Compare March 3, 2026 11:24
@lionel- lionel- force-pushed the task/r-dev-tests branch from aea3008 to b665251 Compare March 3, 2026 12:31
@lionel- lionel- requested a review from DavisVaughan March 3, 2026 12:34

// Do any have a usage section?
headers.any(|header| header.html() == "<h3>Usage</h3>")
headers.any(|header| elt_text(header).trim() == "Usage")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know what the change in R was?

Did you look at what this is connected to and try to interactively cause whatever LSP feature it is connected to to trigger in R-devel and R-release after this change? I just really want to make sure we don't accidentally regress on something here, and I'm not sure we have the best coverage at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R -q -e 'cat(tools::Rd2HTML(utils:::.getHelpFile(help("match"))))' 2>/dev/null | grep '<h3' 

On R 4.5:

<h3>Description</h3>
<h3>Usage</h3>
<h3>Arguments</h3>
<h3>Details</h3>
<h3>Value</h3>
<h3>References</h3>
<h3>See Also</h3>
<h3>Examples</h3>

On R 4.6:

<h3 id='_sec_description'>Description</h3>
<h3 id='_sec_usage'>Usage</h3>
<h3 id='_sec_arguments'>Arguments</h3>
<h3 id='_sec_details'>Details</h3>
<h3 id='_sec_value'>Value</h3>
<h3 id='_sec_references'>References</h3>
<h3 id='_sec_seealso'>See Also</h3>
<h3 id='_sec_examples'>Examples</h3>

@lionel- lionel- force-pushed the task/r-dev-tests branch 2 times, most recently from e544706 to e0bfc6a Compare March 4, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Ark on R-devel

2 participants