Open
Conversation
761af84 to
aea3008
Compare
aea3008 to
b665251
Compare
DavisVaughan
approved these changes
Mar 3, 2026
|
|
||
| // Do any have a usage section? | ||
| headers.any(|header| header.html() == "<h3>Usage</h3>") | ||
| headers.any(|header| elt_text(header).trim() == "Usage") |
Contributor
There was a problem hiding this comment.
Do you happen to know what the change in R was?
Did you look at what this is connected to and try to interactively cause whatever LSP feature it is connected to to trigger in R-devel and R-release after this change? I just really want to make sure we don't accidentally regress on something here, and I'm not sure we have the best coverage at the moment.
Contributor
Author
There was a problem hiding this comment.
R -q -e 'cat(tools::Rd2HTML(utils:::.getHelpFile(help("match"))))' 2>/dev/null | grep '<h3'
On R 4.5:
<h3>Description</h3>
<h3>Usage</h3>
<h3>Arguments</h3>
<h3>Details</h3>
<h3>Value</h3>
<h3>References</h3>
<h3>See Also</h3>
<h3>Examples</h3>
On R 4.6:
<h3 id='_sec_description'>Description</h3>
<h3 id='_sec_usage'>Usage</h3>
<h3 id='_sec_arguments'>Arguments</h3>
<h3 id='_sec_details'>Details</h3>
<h3 id='_sec_value'>Value</h3>
<h3 id='_sec_references'>References</h3>
<h3 id='_sec_seealso'>See Also</h3>
<h3 id='_sec_examples'>Examples</h3>
e544706 to
e0bfc6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1066
To track upstream breaking changes to critical components of our infrastructure:
Second commit fixes sensitivity of a test on HTML produced by R: