Skip to content

Test on r-devel #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lionel- wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

Test on r-devel #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d5e92f
Test on r-devel
lionel- Mar 2, 2026
e0bfc6a
Less strict matching logic in R html tests
lionel- Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:
- { rust: 'stable', r: '4.2' }
# Nightly rust
- { rust: 'nightly', r: 'release' }
# Track upstream breaking changes
- { rust: 'stable', r: 'devel' }
timeout-minutes: 40
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions crates/ark/src/lsp/help.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ impl RHtmlHelp {
let mut headers = x.select(&selector);

// Do any have a usage section?
headers.any(|header| header.html() == "<h3>Usage</h3>")
headers.any(|header| elt_text(header).trim() == "Usage")
Copy link
Contributor

@DavisVaughan DavisVaughan Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know what the change in R was?

Did you look at what this is connected to and try to interactively cause whatever LSP feature it is connected to to trigger in R-devel and R-release after this change? I just really want to make sure we don't accidentally regress on something here, and I'm not sure we have the best coverage at the moment.

Copy link
Contributor Author

@lionel- lionel- Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

R -q -e 'cat(tools::Rd2HTML(utils:::.getHelpFile(help("match"))))' 2>/dev/null | grep '<h3'

On R 4.5:

<h3>Description</h3>
<h3>Usage</h3>
<h3>Arguments</h3>
<h3>Details</h3>
<h3>Value</h3>
<h3>References</h3>
<h3>See Also</h3>
<h3>Examples</h3>

On R 4.6:

<h3 id='_sec_description'>Description</h3>
<h3 id='_sec_usage'>Usage</h3>
<h3 id='_sec_arguments'>Arguments</h3>
<h3 id='_sec_details'>Details</h3>
<h3 id='_sec_value'>Value</h3>
<h3 id='_sec_references'>References</h3>
<h3 id='_sec_seealso'>See Also</h3>
<h3 id='_sec_examples'>Examples</h3>

}

pub fn topic(&self) -> Option<String> {
Expand Down Expand Up @@ -192,7 +192,7 @@ impl RHtmlHelp {
let selector = Selector::parse("h3").unwrap();
let mut headers = self.html.select(&selector);
let header = headers
.find(|node| node.html() == "<h3>Arguments</h3>")
.find(|node| elt_text(*node).trim() == "Arguments")
.into_result()?;

let mut elt = header;
Expand Down