Add Plugin API v3.6.0 config reload support#5
Merged
dmortondev merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
b1f13d3 to
42bbf46
Compare
Implement the Config Reload request/response pair from Plugin API v3.6.0 (Launcher v2.19.0), allowing the Launcher to request plugins to reload their configuration at runtime without restarting. Wire protocol: - Message type 202 for both request and response - Response includes errorType (enum) and errorMessage (string) - Non-streaming request-response pattern SDK changes: - Add ConfigReloadErrorType enum with Unknown/None/Load/Validate/Save - Add ConfigReloadRequest/ConfigReloadResponse protocol types - Add ConfigReloadablePlugin optional interface (ReloadConfig method) - Add ConfigReloadError type for classified error reporting - Auto-respond with success for plugins that don't implement the interface - Export RequestFromJSON for test access to protocol deserialization Testing: - Protocol serialization/deserialization tests - Handler dispatch tests (not implemented, success, typed error, plain error, wrapped error) - ConfigReloadErrorType.String() tests - Mock ResponseWriter support for config reload Documentation: - Update version references (v3.5 → v3.6) across docs - Add configuration reloading section to GUIDE.md - Update CHANGELOG.md with feature description
42bbf46 to
f40ecee
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Config Reload request/response pair from Plugin API v3.6.0 (Launcher v2.19.0), allowing the Launcher to request plugins to reload their configuration at runtime without restarting.
ConfigReloadablePluginoptional interface — plugins implementReloadConfig(ctx context.Context) errorto handle reload requestsConfigReloadErrortype for classified reload failures (Load,Validate,Save) andConfigReloadErrorTypeenumConfigReloadablePluginautomatically send a success responseerrorType(int enum) anderrorMessage(string)Changes
api/types.go,api/types_test.gointernal/protocol/rpc.go,internal/protocol/stream.go,internal/protocol/rpc_test.golauncher/launcher.go,launcher/launcher_test.goplugintest/mocks.goAGENTS.md,README.md,CHANGELOG.md,docs/API.md,docs/ARCHITECTURE.md,docs/GUIDE.mdDesign decisions
BootstrappedPlugin,MultiClusterPlugin, andLoadBalancedPluginpatterns — type assertion in the handler dispatchReloadConfigreturnserror; plugins return*ConfigReloadErrorfor classified errors (Load/Validate/Save) or plainerrorfor unclassified failures (mapped toReloadErrorUnknown)RequestFromJSONexport: Renamed fromrequestFromJSONto enable handler dispatch tests without depending on internal struct constructionTest plan
just build— compiles cleanlyjust test— all tests pass (16 new tests)just lint— 0 issuesjust build-examples— examples still buildConfigReloadRequestdeserializes from JSON,ConfigReloadResponseserializes with correctmessageType,errorType,errorMessageConfigReloadError, plain error, wrappedConfigReloadErrorConfigReloadErrorType.String()covers all enum values plus invalid input