feat: produce note on usage of local thresholds #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we added in the 'notes' feature, and this infrastructure makes it possible for Pointblank to store and report additional pertinent information (in the footer of the table) for specific steps.
This PR implements notes for when there are thresholds set for specific steps (i.e., not global thresholds, perhaps overriding global). What you get are step-specific footnotes that provide the local thresholds values. If thresholds are deactivated for a step (i.e., global thresholds are set but
pb.Thresholds()is called on a step), a note will indicate that global thresholds are disregarded for that step.These notes are also localized. Here's an example of notes on local thresholds when using
lang="de":