feat: add environments #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
tdstein
commented
Dec 12, 2024
Comment on lines
+308
to
+311
| @property | ||
| @requires(version="2023.05.0") | ||
| def environments(self) -> Environments: | ||
| return _ResourceSequence(self._ctx, "v1/environments") |
Collaborator
Author
There was a problem hiding this comment.
This is where the implicit type-checking occurs. The method signature returns the Environments protocol while the implementation returns _ResourceSequence.
Closed
schloerke
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds environment support.
Adds environment support using base implementations at runtime and implicit type-checking for static typing.
Closes #307