fix: Update with_user_session_token method to be more robust and allow local development #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconflitti-pbc
requested review from
jonkeane,
nealrichardson,
schloerke,
tdstein and
toph-allen
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mconflitti-pbc
changed the title
toph-allen
reviewed
Jan 17, 2025
Collaborator
toph-allen
left a comment
toph-allen
left a comment
There was a problem hiding this comment.
This generally looks good to me. Just one question / thought, but it's a very soft suggestion. I'll leave it to @tdstein to give the actual approval though. :)
tdstein
reviewed
Jan 22, 2025
tdstein
approved these changes
Jan 22, 2025
Collaborator
tdstein
left a comment
tdstein
left a comment
There was a problem hiding this comment.
Thanks for working through the feedback. Looks good to merge!
mconflitti-pbc
deleted the
mconflitti/update-visitor-api-key-client-creation
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from discussions:
On hold until we confirm final terminology: visitor vs viewer with @kellobri