Conversation
✅ Deploy Preview for positron-posit-co ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No rush on these reviews, but @jonvanausdeln @jthomasmock @petetronic can you take a look at these thoughts along with the deploy preview, and share what you think will/won't work for us? |
|
This looks good to me. I do like keeping old release notes around, I know users will ask about them and they are handy for QA and issue bisecting. The use of |
|
This is what it would look like in Positron: The editor tab label needs an update to show Positron's version instead of code-oss but that's outside of this PR. The release notes view is just an editor that renders the markdown and adds in some styling and the Using There's also a command to preview a markdown file as release notes. Another thing to note: VSCode doesn't publish separate patch release notes. It links to the same file and it's updated to the new commits in the patch. This is also the use case for |
|
Thank you so much for looking at this, @timtmok! 🙌
|
|
Note that we can't use includes with a dynamically generated filename: quarto-dev/quarto-cli#11681 |
|
@juliasilge It's just searching for an element to determine where to put the checkbox. It's a quick change in Positron to use the first Or placing any kind of element that can be found with a HTML document selector would work too. @petetronic What do you think about placing the release notes in S3? They'll be available through the CDN and that would be the link to use. We have the credentials set up to invalidate the file if we need to update the release notes. Positron itself can build the URL to it using the base update URL (https://cdn.posit.co/positron) from the |
|
In e2ec63c I added some of the fancy settings links, so we should confirm that works from within Positron itself. If it's not good, we'll just go back to no fancy links on release notes. |
|
@timtmok RE that checkbox:
How hard would it be to show up after the highlights section, i.e. before the second H3 header? |
@juliasilge It wouldn't be too hard. I've been thinking it would be best to use an HTML element place the checkbox exactly where we want and be able to see in the markdown where it would go. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@juliasilge I've updated the Github action to publish the release note. I'll wait for this to merge before merging mine: #97 |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces initial release notes for the RC release along with a template for future release notes and updates to the download page to include the new notes.
- Adds a new release notes file (release.md) to be used in-product during releases
- Introduces a release notes template (release-notes-template.md) for consistent future entries
- Updates download.qmd and its frozen HTML to integrate the release notes into the installer page
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| release-notes/release.md | New release notes with highlights, changelog, bug fixes, and dependency updates |
| release-notes/release-notes-template.md | A template for creating future release notes |
| download.qmd | Adjusted headings and added an include for the new release notes |
| _freeze/download/execute-results/html.json | Updated hash and pre-rendered markdown content reflecting download page changes |
Comments suppressed due to low confidence (1)
release-notes/release.md:46
- It appears the markdown link for issue #7838 is missing a closing bracket. Adding the missing bracket to correctly render the link would improve clarity.
- [[#7838](https://github.com/posit-dev/positron/issues/7838) The Assistant project tree tool now takes parameters to filter the tree output.
|
This PR is now ready for a real review!
If we can get this reviewed at the beginning of next week (Monday?) then @timtmok can have the markdown ready to go into S3, so it is available when we push the new builds on Wednesday and people start getting them. cc @jthomasmock |
|
OK, I think this is the last of a flurry of PRs for our FIRST STABLE RELEASE! 🥳 |





No rush on this, but I want to start getting feedback on our initial go at release notes for RC and beyond. Some things to note:
release.mdcan be slurped up into the product before a release is built, for in-product release notes.next.md,release.md, and then, say,release-2025-07.md.next.mdduring the release, to prep the release notes.next.mdcan move torelease.mdand the currentrelease.mdcan move to something likerelease-2025-07.md.