chore: More minor type changes in prep for py-htmltools updates #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…within the nav's data-value
schloerke
changed the title
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Sep 23, 2024
* main: chore: Fix `langchain_core` test that used a new `Sequence` type (posit-dev#1697) tests(input_slider): add kitchensink tests for input_slider (posit-dev#1691) chore: More minor type changes in prep for py-htmltools updates (posit-dev#1693) chore: Add types and check action for py-htmltools (posit-dev#1692) Anticipate `htmltools.HTML` no longer inheriting from `str` (posit-dev#1690) tests(input_select): Add kitchensink tests for input_select and input_selectize (posit-dev#1686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nav panel value is currently given as a
str. I believe we should not allow for it to be anHTML()object.So, keeping the types as
str, the final retrieved attribute value should be str (and notHTML()). If there somehow happens to have an HTML value, we will convert it to a str at retrieval timeRelated #1692