Skip to content

chore: More minor type changes in prep for py-htmltools updates #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore: More minor type changes in prep for py-htmltools updates #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shiny/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def resolve(
"""
...

def get_value(self) -> Optional[str]:
def get_value(self) -> str | None:
"""
Get the value of this navigation item (if any).

Expand Down
9 changes: 6 additions & 3 deletions shiny/ui/_navs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,14 @@ def resolve(

return nav, content

def get_value(self) -> str | HTML | None:
def get_value(self) -> str | None:
if self.content is None:
return None
a_tag = cast(Tag, self.nav.children[0])
return a_tag.attrs.get("data-value", None)
data_value_attr = a_tag.attrs.get("data-value", None)
if isinstance(data_value_attr, HTML):
data_value_attr = str(data_value_attr)
return data_value_attr

def tagify(self) -> None:
raise NotImplementedError(
Expand Down Expand Up @@ -279,7 +282,7 @@ def resolve(
content.children,
)

def get_value(self) -> Optional[str]:
def get_value(self) -> str | None:
for x in self.nav_controls:
val = x.get_value()
if val:
Expand Down
Loading