Skip to content

bug: Fix narwhals test covering new NestedType #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

bug: Fix narwhals test covering new NestedType #1836

merged 2 commits into from
Feb 3, 2025

Conversation

@schloerke
Copy link
Collaborator

  • Generalize to allow for ending with *Type

@schloerke schloerke marked this pull request as ready for review February 3, 2025 16:01
@schloerke schloerke requested a review from karangattu February 3, 2025 16:01
karangattu
karangattu reviewed Feb 3, 2025
View reviewed changes
karangattu
karangattu approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@karangattu karangattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schloerke
schloerke commented Feb 3, 2025
View reviewed changes
@schloerke schloerke enabled auto-merge (squash) February 3, 2025 16:10
@schloerke schloerke merged commit 184a9eb into main Feb 3, 2025
41 checks passed
@schloerke schloerke deleted the narwhals_nested_type branch February 3, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karangattu karangattu karangattu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schloerke @karangattu