Skip to content

bug: Fix narwhals test covering new NestedType #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

bug: Fix narwhals test covering new NestedType #1836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
762c9d5
fix narwhals test
schloerke Feb 3, 2025
b6258b4
Update tests/pytest/test_render_data_frame_tbl_data.py
schloerke Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/pytest/test_render_data_frame_tbl_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,11 +366,14 @@ def test_dtype_coverage():
for dtype_name in dtype_names:

# Skip known types or imports that are not dtypes
if dtype_name.endswith("Type"):
# "DType",
# "NestedType",
# "NumericType",
# "TemporalType",
continue
if dtype_name in (
# narwhals
"DType",
"NumericType",
"TemporalType",
"Unknown",
# typing import
"Literal",
Expand Down
Loading