chore(pyright): Bump pyright version to >=1.1.398
#1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
shiny/ui/_page.py:754
- Removing this cast may lead to type-checker issues if 'page_fn' does not clearly conform to the expected type. If the new pyright version handles implicit conversions, please verify that 'page_fn' is always callable as expected.
page_fn = cast(Callable[..., Tag], page_fn)
shiny/_app.py:11
- Removing this import is fine if starlette.exceptions is not used elsewhere, but please confirm that no exception handling or related logic depends on it.
import starlette.exceptions
schloerke
commented
Apr 8, 2025
| from typing import Any, Callable, Literal, Mapping, Optional, TypeVar, cast | ||
|
|
||
| import starlette.applications | ||
| import starlette.exceptions |
There was a problem hiding this comment.
@jcheng5 Is this import needed? pyright flagged it as unused. (It is not directly used within the code other than this import statement.)
I believe we can remove it. Just wanted to be sure it didn't have any side effects from being accessed.
|
I believe these changes are good. Merging to unlock pyright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.