Skip to content

chore(pyright): Bump pyright version to >=1.1.398 #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

chore(pyright): Bump pyright version to >=1.1.398 #1964

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3699405
Bump pyright version to `>=1.1.398`
schloerke Apr 8, 2025
c0bf5dc
Fix pyright lints
schloerke Apr 8, 2025
018a8a4
Merge branch 'main' into pyright-update
schloerke Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ dev = [
"isort>=5.10.1",
"libsass>=0.23.0",
"brand_yml>=0.1.0",
"pyright>=1.1.383,<1.1.395",
"pyright>=1.1.398",
"pre-commit>=2.15.0",
"wheel",
"matplotlib",
Expand Down
1 change: 0 additions & 1 deletion shiny/_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from typing import Any, Callable, Literal, Mapping, Optional, TypeVar, cast

import starlette.applications
import starlette.exceptions
Copy link
Collaborator Author

@schloerke schloerke Apr 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcheng5 Is this import needed? pyright flagged it as unused. (It is not directly used within the code other than this import statement.)

I believe we can remove it. Just wanted to be sure it didn't have any side effects from being accessed.

import starlette.middleware
import starlette.routing
import starlette.websockets
Expand Down
3 changes: 1 addition & 2 deletions shiny/ui/_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
)

from copy import copy
from typing import Any, Callable, Literal, Optional, Sequence, cast
from typing import Any, Callable, Literal, Optional, Sequence

from htmltools import (
MetadataNode,
Expand Down Expand Up @@ -752,7 +752,6 @@ def page_auto(
)

# If we got here, _page_fn is not None, but the type checker needs a little help.
page_fn = cast(Callable[..., Tag], page_fn)
return page_fn(*args, **kwargs)


Expand Down
Loading