Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 14, 2025

This pull request replaces the use of the appdirs library with platformdirs across the codebase to update dependencies and ensure compatibility with the latest library standards. The changes include updates to dependencies, build scripts, and code references.

Dependency Updates:

  • Replaced appdirs>=1.4.4 with platformdirs>=3.0.0 in the dependencies list.

Build Script Updates:

  • Updated the target for creating type stubs from appdirs to platformdirs and adjusted the pyright-typings dependency list accordingly.

Code Updates:

  • Replaced the appdirs library with platformdirs for determining the user cache directory, including updating the user_cache_dir function call to use the appname argument.

Fixes #2011.

Copilot AI changed the title [WIP] [Bug]: appdirs is officialy deprecated; please replace by platformdirs Replace deprecated appdirs with platformdirs Jul 14, 2025
Copilot AI requested a review from karangattu July 14, 2025 18:21
Copilot finished work on behalf of karangattu July 14, 2025 18:21
@karangattu karangattu changed the title Replace deprecated appdirs with platformdirs fix(dependency): Replace deprecated appdirs with platformdirs Jul 14, 2025
@karangattu karangattu requested review from schloerke and wch July 15, 2025 05:05
Replaces references to 'appdirs' with 'platformdirs' for type stub generation using pyright. Updates the pyright-typings target and related commands accordingly.
@karangattu karangattu marked this pull request as ready for review July 16, 2025 04:20
@schloerke schloerke enabled auto-merge (squash) July 21, 2025 18:47
@schloerke
Copy link
Collaborator

Failures unrelated to PR. Merging.

@schloerke schloerke disabled auto-merge July 21, 2025 19:00
@schloerke schloerke merged commit a713ebd into main Jul 21, 2025
51 of 54 checks passed
@schloerke schloerke deleted the copilot/fix-2011 branch July 21, 2025 19:00
@wch
Copy link
Collaborator

wch commented Jul 21, 2025

When we update py-shiny in shinylive, we will have to make a few manual changes to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: appdirs is officialy deprecated; please replace by platformdirs

4 participants