Skip to content

fix(dependency): Replace deprecated appdirs with platformdirs #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2025
Merged

fix(dependency): Replace deprecated appdirs with platformdirs #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed7d638
Initial plan
Copilot Jul 14, 2025
7553eca
Replace deprecated appdirs with platformdirs
Copilot Jul 14, 2025
1ed5e43
Merge branch 'main' into copilot/fix-2011
karangattu Jul 15, 2025
92c1e6e
Update Makefile to use platformdirs instead of appdirs
karangattu Jul 15, 2025
14b2dac
reduce version requirement
schloerke Jul 21, 2025
33e6798
no need to make typings for a typed package
schloerke Jul 21, 2025
1c8b7fb
cosmetic
schloerke Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ clean-test: FORCE
rm -fr .pytest_cache
rm -rf typings/

typings/appdirs:
@echo "Creating appdirs stubs"
pyright --createstub appdirs
typings/folium:
@echo "Creating folium stubs"
pyright --createstub folium
Expand All @@ -75,7 +72,7 @@ typings/matplotlib/__init__.pyi:
mv typings/python-type-stubs/stubs/matplotlib typings/
rm -rf typings/python-type-stubs

pyright-typings: typings/appdirs typings/folium typings/uvicorn typings/seaborn typings/matplotlib/__init__.pyi
pyright-typings: typings/folium typings/uvicorn typings/seaborn typings/matplotlib/__init__.pyi

check: check-format check-lint check-types check-tests ## check code, style, types, and test (basic CI)
check-fix: format check-lint check-types check-tests ## check and format code, style, types, and test
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ dependencies = [
"markdown-it-py>=1.1.0",
"mdit-py-plugins>=0.3.0",
"linkify-it-py>=1.0",
"appdirs>=1.4.4",
"platformdirs>=2.1.0",
"asgiref>=3.5.2",
"packaging>=20.9",
"watchfiles>=0.18.0;platform_system!='Emscripten'",
Expand Down
14 changes: 4 additions & 10 deletions shiny/_static.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,10 @@ def remove_shinylive_local(


def get_default_shinylive_dir() -> Path:
import appdirs

return (
Path(
appdirs.user_cache_dir( # pyright: ignore[reportUnknownMemberType, reportUnknownArgumentType]
"shiny"
)
)
/ "shinylive"
)
import platformdirs

user_cache_dir = platformdirs.user_cache_dir("shinylive")
return Path(user_cache_dir) / "shinylive"


def _installed_shinylive_versions(shinylive_dir: Optional[Path] = None) -> list[str]:
Expand Down
Loading