Skip to content

fix(accordion): Fix insert_accordion_panel to work with shiny.express.ui.accordion_panel() #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix(accordion): Fix insert_accordion_panel to work with shiny.express.ui.accordion_panel() #2031

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eaf5074
Initial plan
Copilot Jul 14, 2025
1232b67
Fix insert_accordion_panel to work with express ui.accordion_panel
Copilot Jul 14, 2025
607f47c
Merge branch 'main' into copilot/fix-1802
karangattu Jul 15, 2025
80014b3
Reorder TYPE_CHECKING imports in _accordion.py
karangattu Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions shiny/ui/_accordion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from __future__ import annotations

from typing import TYPE_CHECKING, Literal, Optional, TypeVar
from typing import TYPE_CHECKING, Literal, Optional, TypeVar, Union

from htmltools import Tag, TagAttrs, TagAttrValue, TagChild, css, tags

Expand All @@ -15,6 +15,7 @@
from .css._css_unit import CssUnit, as_css_unit

if TYPE_CHECKING:
from ..express._recall_context import RecallContextManager
from ..session import Session

__all__ = (
Expand Down Expand Up @@ -447,7 +448,7 @@ def update_accordion(
@add_example()
def insert_accordion_panel(
id: str,
panel: AccordionPanel,
panel: Union[AccordionPanel, "RecallContextManager[AccordionPanel]"],
target: Optional[str] = None,
position: Literal["after", "before"] = "after",
session: Optional[Session] = None,
Expand Down Expand Up @@ -486,14 +487,25 @@ def insert_accordion_panel(
if position not in ("after", "before"):
raise ValueError("`position` must be either 'after' or 'before'")
session = require_active_session(session)

# Handle both AccordionPanel and RecallContextManager[AccordionPanel]
from ..express._recall_context import RecallContextManager

if isinstance(panel, RecallContextManager):
# This is a RecallContextManager, extract the AccordionPanel
accordion_panel = panel.fn(*panel.args, **panel.kwargs)
else:
# This is already an AccordionPanel
accordion_panel = panel

# Add accordion ID to panel; Used when `accordion(multiple=False)`
panel._accordion_id = id
accordion_panel._accordion_id = id

_send_panel_message(
id,
session,
method="insert",
panel=session._process_ui(panel.resolve()),
panel=session._process_ui(accordion_panel.resolve()),
target=None if target is None else _assert_str(target),
position=position,
)
Expand Down
Loading