-
Couldn't load subscription status.
- Fork 115
fix: Fix 1703 Options selectize not working in modules #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks good, please update the CHANGELOG and maybe worth a test? |
cpsievert
reviewed
Aug 7, 2025
Co-authored-by: Carson Sievert <[email protected]>
|
We're moving this over here and adding a test for it. Initial fix for overwriting: to before in |
cpsievert
reviewed
Aug 7, 2025
Co-authored-by: Carson Sievert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue as reported in #1703 where passing
optionsintoupdate_selectize()whenserver=Truebreaks the selectize menu (choices do not load, search/filtering does not occur).Additional problems discovered while addressing this are documented here: #2052