-
Couldn't load subscription status.
- Fork 115
fix: Fix 1703 Options selectize not working in modules #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ffad4cc
Fix resolve id
elnelson575 cf61845
Add back whitespace
elnelson575 cd544e6
Merge branch 'main' into fix/options-update-selectize
elnelson575 30e211e
Added tests
elnelson575 f70b0af
Updating changelog
elnelson575 add4552
Merging
elnelson575 db8a825
Fixing lint
elnelson575 0ccf0e8
Fixing types
elnelson575 d55f6ac
Update tests/playwright/shiny/components/selectize/app.py
elnelson575 9ef4067
Updating
elnelson575 c276b28
Merge
elnelson575 e2e9a8e
Debugging search filter
elnelson575 8fb5dd5
placeholder test
elnelson575 a06761c
Update CHANGELOG.md
elnelson575 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| from shiny import App, Inputs, Outputs, Session, module, reactive, ui | ||
|
|
||
|
|
||
| @module.ui | ||
| def reprex_selectize_ui(): | ||
| return ui.input_selectize("x", "Server side selectize", choices=[], multiple=True) | ||
|
|
||
|
|
||
| @module.server | ||
| def reprex_selectize_server( | ||
| input: Inputs, output: Outputs, session: Session, starting_value: int = 0 | ||
elnelson575 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ): | ||
| @reactive.effect | ||
| def _(): | ||
| ui.update_selectize( | ||
| "x", | ||
| choices=[f"Foo {i}" for i in range(3)], | ||
| server=False, | ||
| options={"placeholder": "Search"}, | ||
| ) | ||
|
|
||
|
|
||
| app_ui = ui.page_fluid(reprex_selectize_ui("reprex_selectize")) | ||
|
|
||
|
|
||
| def server(input: Inputs, output: Outputs, session: Session): | ||
| reprex_selectize_server("reprex_selectize") | ||
|
|
||
|
|
||
| app = App(app_ui, server, debug=True) | ||
15 changes: 15 additions & 0 deletions
15
tests/playwright/shiny/components/selectize/test_selectize.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # import pytest | ||
| from playwright.sync_api import Page | ||
|
|
||
| from shiny.playwright import controller | ||
| from shiny.run import ShinyAppProc | ||
|
|
||
|
|
||
| def test_selectize(page: Page, local_app: ShinyAppProc) -> None: | ||
| page.goto(local_app.url) | ||
|
|
||
| selectize_menu = controller.InputSelectize(page, "reprex_selectize-x") | ||
| selectize_menu.expect_choices(["Foo 0", "Foo 1", "Foo 2"]) | ||
| selectize_menu.expect_multiple(True) | ||
| selectize_menu.set(["Foo 0", "Foo 1"]) | ||
| selectize_menu.expect_selected(["Foo 0", "Foo 1"]) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.