[Fix] packages/react
issue with useQuery
not supporting dynamic query parameters
#325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue reported at #323.
Dynamic query dependencies would warn with the following if the query parameter array changed in size:
Warning: The final argument passed to useMemo changed size between renders. The order and size of this array must remain constant. Previous: [] Incoming: [xxxxxxxxxxxxx]
Tested with the following to verify that it works now:
The change from
React.useMemo(() => {}, [...array]);
toReact.useMemo(() => {},[JSON.stringify(array)])
should not introduce any issues, as valid query parameters are expected to be serialisable.