Skip to content

[Fix] packages/react issue with useQuery not supporting dynamic query parameters #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[Fix] packages/react issue with useQuery not supporting dynamic query parameters #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10c5b15
Fixed issue with `useQuery` not supporting dynamic query parameters
Chriztiaan Oct 1, 2024
af14633
Merge branch 'main' into fix/use-query-dynamic-query-parameters
Chriztiaan Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-jeans-prove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/react': patch
---

Fixed issue with `useQuery` not supporting dynamic query parameters.
2 changes: 1 addition & 1 deletion packages/react/src/hooks/useQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const useQuery = <T = any>(
const [isFetching, setIsFetching] = React.useState(true);
const [tables, setTables] = React.useState([]);

const memoizedParams = React.useMemo(() => queryParameters, [...queryParameters]);
const memoizedParams = React.useMemo(() => queryParameters, [JSON.stringify(queryParameters)]);
const memoizedOptions = React.useMemo(() => options, [JSON.stringify(options)]);
const abortController = React.useRef(new AbortController());

Expand Down
Loading