Skip to content

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Oct 21, 2024

The isFetching value was stuck on true in react-native projects if either the query or parameters changed. It seems state changes trigger in a slightly different order.

Verified that this package works via a dev release on the reporter's react-native project and on the react project that originally needed improvements for isFetching.

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: eb7ad4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@powersync/react Patch
@powersync/react-native Patch
@powersync/tanstack-react-query Patch
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Chriztiaan Chriztiaan changed the title fix: useQuery()'s' isFetching value was stuck as true in react-native. fix: useQuery()'s isFetching value was stuck as true in react-native. Oct 22, 2024
@Chriztiaan Chriztiaan marked this pull request as ready for review October 22, 2024 18:56
Copy link
Contributor

@mugikhan mugikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Chriztiaan Chriztiaan merged commit c8658ca into main Oct 23, 2024
5 checks passed
@Chriztiaan Chriztiaan deleted the fix/is-fetching-react-native branch October 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants