Skip to content

fix: useQuery()'s isFetching value was stuck as true in react-native. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: useQuery()'s isFetching value was stuck as true in react-native. #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6180ab3
fix: `useQuery()`'s' `isFetching` value was stuck as true when used i…
Chriztiaan Oct 21, 2024
eb7ad4d
Merge branch 'main' into fix/is-fetching-react-native
Chriztiaan Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-chefs-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/react': patch
---

Fixed `useQuery()`'s' `isFetching` value staying true when used in react-native environment.
4 changes: 2 additions & 2 deletions packages/react/src/hooks/useQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,21 @@ export const useQuery = <T = any>(
);

const handleResult = (result: T[]) => {
previousQueryRef.current = { sqlStatement, memoizedParams };
setData(result);
setIsLoading(false);
setIsFetching(false);
setError(undefined);
previousQueryRef.current = { sqlStatement, memoizedParams };
};

const handleError = (e: Error) => {
previousQueryRef.current = { sqlStatement, memoizedParams };
setData([]);
setIsLoading(false);
setIsFetching(false);
const wrappedError = new Error('PowerSync failed to fetch data: ' + e.message);
wrappedError.cause = e;
setError(wrappedError);
previousQueryRef.current = { sqlStatement, memoizedParams };
};

const fetchData = async () => {
Expand Down
Loading