[node] Upgrade undici and remove ErrorRecordingDispatcher for websockets #652
+779
−523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In earlier versions, undici did not include the underlying cause of errors on websocket connection failures, instead just giving a generic
Received network error or non-101 status code.
, making debugging difficult. This includes connection failures, TLS failures, proxy errors, etc. As a workaround, we used a custom Dispatcher to record the underlying errors.In v7.11.0, this was fixed by adding the
cause
property. This PR now removes the custom Dispatcher and just relies on the upstream directly.Note that this does change the error reported, and you have to use
error.cause[.cause]
to get to the underlying issue.Sample error (502 on a proxy) with this change:
Before, with ErrorRecordingDispatcher:
Before, without ErrorRecordingDispatcher: