Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-onions-dance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/node': minor
---

Upgrade undici and use the default undici errors for WebSockets.
2 changes: 1 addition & 1 deletion demos/example-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@powersync/node": "workspace:*",
"dotenv": "^16.4.7",
"undici": "^7.10.0"
"undici": "^7.11.0"
},
"devDependencies": {
"ts-node": "^10.9.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"async-lock": "^1.4.0",
"bson": "^6.6.0",
"comlink": "^4.4.2",
"undici": "^7.10.0"
"undici": "^7.11.0"
},
"devDependencies": {
"@powersync/drizzle-driver": "workspace:*",
Expand Down
58 changes: 0 additions & 58 deletions packages/node/src/sync/stream/ErrorRecordingDispatcher.ts

This file was deleted.

14 changes: 1 addition & 13 deletions packages/node/src/sync/stream/NodeRemote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
ProxyAgent,
WebSocket as UndiciWebSocket
} from 'undici';
import { ErrorRecordingDispatcher } from './ErrorRecordingDispatcher.js';

export const STREAMING_POST_TIMEOUT_MS = 30_000;

Expand Down Expand Up @@ -65,26 +64,15 @@ export class NodeRemote extends AbstractRemote {
protected createSocket(url: string): globalThis.WebSocket {
// Create dedicated dispatcher for this WebSocket
const baseDispatcher = this.getWebsocketDispatcher(url);
const errorRecordingDispatcher = new ErrorRecordingDispatcher(baseDispatcher);

// Create WebSocket with dedicated dispatcher
const ws = new UndiciWebSocket(url, {
dispatcher: errorRecordingDispatcher,
dispatcher: baseDispatcher,
headers: {
'User-Agent': this.getUserAgent()
}
});

errorRecordingDispatcher.onError = (error: Error) => {
// When we receive an error from the Dispatcher, emit the event on the websocket.
// This will take precedence over the WebSocket's own error event, giving more details on what went wrong.
const event = new ErrorEvent('error', {
error,
message: error.message
});
ws.dispatchEvent(event);
};

return ws as globalThis.WebSocket;
}

Expand Down
Loading