fix: null pointer in updateHasSynced #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicGBauer
changed the title
stevensJourney
previously approved these changes
Feb 10, 2025
stevensJourney
approved these changes
Feb 10, 2025
DominicGBauer
deleted the
fix/null-pointer-in-update-has-synced-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue in
updateHasSyncedwhere null timestamp was allowed through. The issue was thatcurrentStatus.hasSyncedis initialized tonulland notfalseso this checkif (hasSynced != currentStatus.hasSynced)was always true.Testing
Tested in Swift SDK and ran the supabase todolist app