Skip to content

fix: null pointer in updateHasSynced #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025
Merged

fix: null pointer in updateHasSynced #118

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2f43e7
fix: revert updateHasSynced change that removed null pointer handling
DominicGBauer Feb 10, 2025
4c56ba4
fix: timestamp null pointer
DominicGBauer Feb 10, 2025
578415c
docs: update changelog
DominicGBauer Feb 10, 2025
d9ab1fe
chore: add null check
DominicGBauer Feb 10, 2025
1c668ef
chore: add null check
DominicGBauer Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.0.0-BETA22
* Fix `updateHasSynced` internal null pointer exception

## 1.0.0-BETA21

* Improve error handling for Swift by adding @Throws annotation so errors can be handled in Swift
Expand Down
19 changes: 11 additions & 8 deletions core/src/commonMain/kotlin/com/powersync/db/PowerSyncDatabaseImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,18 @@ internal class PowerSyncDatabaseImpl(
}

private suspend fun updateHasSynced() {
// Query the database to see if any data has been synced.
data class SyncedAt(
val syncedAt: String?,
)
// Query the database to see if any data has been synced
val timestamp =
internalDb.getOptional("SELECT powersync_last_synced_at() as synced_at", null) { cursor ->
cursor.getString(0) ?: ""
}

val hasSynced = timestamp != ""
if (hasSynced != currentStatus.hasSynced) {
val formattedDateTime = "${timestamp!!.replace(" ", "T").toLocalDateTime()}Z"
internalDb
.getOptional("SELECT powersync_last_synced_at() as synced_at", null) { cursor ->
SyncedAt(syncedAt = cursor.getStringOptional("synced_at"))
}?.syncedAt
val hasSynced = timestamp != null
if (currentStatus.hasSynced != null && hasSynced != currentStatus.hasSynced) {
val formattedDateTime = "${timestamp!!.replace(" ","T").toLocalDateTime()}Z"
val lastSyncedAt = Instant.parse(formattedDateTime)
currentStatus.update(hasSynced = hasSynced, lastSyncedAt = lastSyncedAt)
}
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ development=true
RELEASE_SIGNING_ENABLED=true
# Library config
GROUP=com.powersync
LIBRARY_VERSION=1.0.0-BETA21
LIBRARY_VERSION=1.0.0-BETA22
GITHUB_REPO=https://github.com/powersync-ja/powersync-kotlin.git
# POM
POM_URL=https://github.com/powersync-ja/powersync-kotlin/
Expand Down