Skip to content

fix: transaction resulting in race condition when not using the correct context #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: transaction resulting in race condition when not using the correct context #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a063ea7
fix: transaction resulting in race condition when not using the corre…
DominicGBauer Dec 18, 2024
62e8e1b
chore: add changelog and version updates
DominicGBauer Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.0.0-BETA12

* Use transaction context in `writeTransaction` in `BucketStorageImpl` to avoid race condition issues in Swift SDK.

## 1.0.0-BETA11

* Update version to fix deployment issue of previous release
Expand Down
6 changes: 3 additions & 3 deletions core/src/commonMain/kotlin/com/powersync/bucket/BucketStorageImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ internal class BucketStorageImpl(

logger.i { "[updateLocalTarget] Updating target to checkpoint $opId" }

return db.writeTransaction {
return db.writeTransaction { tx ->
if (hasCrud()) {
logger.w { "[updateLocalTarget] ps crud is not empty" }
return@writeTransaction false
}

val seqAfter =
db.getOptional("SELECT seq FROM sqlite_sequence WHERE name = '${InternalTable.CRUD}'") {
tx.getOptional("SELECT seq FROM sqlite_sequence WHERE name = '${InternalTable.CRUD}'") {
it.getLong(0)!!
}
?: // assert isNotEmpty
Expand All @@ -112,7 +112,7 @@ internal class BucketStorageImpl(
return@writeTransaction false
}

db.execute(
tx.execute(
"UPDATE ${InternalTable.BUCKETS} SET target_op = CAST(? as INTEGER) WHERE name='\$local'",
listOf(opId),
)
Expand Down
Loading