Swallow exceptions in getCases() when some cases do not have case_metadata#67
Merged
etiennehomer merged 18 commits intomainfrom Feb 18, 2025
Merged
Swallow exceptions in getCases() when some cases do not have case_metadata#67etiennehomer merged 18 commits intomainfrom
etiennehomer merged 18 commits intomainfrom
Conversation
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
antoinebhs
reviewed
Feb 14, 2025
antoinebhs
reviewed
Feb 14, 2025
antoinebhs
reviewed
Feb 14, 2025
antoinebhs
reviewed
Feb 14, 2025
src/main/java/com/powsybl/caseserver/service/FsCaseService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Feb 14, 2025
src/main/java/com/powsybl/caseserver/service/FsCaseService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Feb 14, 2025
src/main/java/com/powsybl/caseserver/service/FsCaseService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Feb 14, 2025
antoinebhs
reviewed
Feb 14, 2025
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Show resolved
Hide resolved
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
etiennehomer
force-pushed
the
swallow_crashes_in_getCases
branch
from
1a1acae to
6a41f57
Compare
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
etiennehomer
changed the title
etiennehomer
changed the title
EtienneLt
reviewed
Feb 17, 2025
Collaborator
|
test OK |
antoinebhs
reviewed
Feb 17, 2025
antoinebhs
reviewed
Feb 17, 2025
antoinebhs
reviewed
Feb 17, 2025
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Show resolved
Hide resolved
antoinebhs
reviewed
Feb 17, 2025
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Show resolved
Hide resolved
antoinebhs
reviewed
Feb 17, 2025
src/test/java/com/powsybl/caseserver/service/S3CaseControllerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Changes the behavior of the getCases() method
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
While executing getCases(), if a case is present on the filesystem but not referenced in the case_metadata database, the method throws an exception and returns a 404.
What is the new behavior (if this is a feature change)?
In such a case, getCases() will return the cases list without the cases non present in the case_metadata db. The error will be logged.
Does this PR introduce a breaking change or deprecate an API?