Skip to content

Restore missing constructor in LoadFlowParameters#3360

Merged
olperr1 merged 3 commits intomainfrom
restore_missing_method_in_LoadFlowParameters
Mar 14, 2025
Merged

Restore missing constructor in LoadFlowParameters#3360
olperr1 merged 3 commits intomainfrom
restore_missing_method_in_LoadFlowParameters

Conversation

@olperr1
Copy link
Copy Markdown
Member

@olperr1 olperr1 commented Mar 14, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

The following public constructor was removed by #3288:

public LoadFlowParameters(List<LoadFlowDefaultParametersLoader>)

What is the new behavior (if this is a feature change)?

  • Restore the constructor
  • Also set the following constructor in public:
public LoadFlowParameters(List<LoadFlowDefaultParametersLoader>, PlatformConfig)

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

The removed constructor was used by open-load-flow in powsybl/powsybl-open-loadflow#1176

…rametersLoader)

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 requested a review from HugoKulesza March 14, 2025 07:31
@olperr1 olperr1 requested a review from flo-dup March 14, 2025 07:31
@olperr1 olperr1 moved this from TODO to Waiting for review in Release 03/2025 Mar 14, 2025
@olperr1 olperr1 requested a review from vidaldid-rte March 14, 2025 07:32
@github-project-automation github-project-automation bot moved this from Waiting for review to Approved in Release 03/2025 Mar 14, 2025
@sonarqubecloud
Copy link
Copy Markdown

@olperr1 olperr1 merged commit 9098d53 into main Mar 14, 2025
8 checks passed
@olperr1 olperr1 deleted the restore_missing_method_in_LoadFlowParameters branch March 14, 2025 13:07
@github-project-automation github-project-automation bot moved this from Approved to Done in Release 03/2025 Mar 14, 2025
pjanecek0 pushed a commit to pjanecek0/powsybl-core that referenced this pull request Mar 14, 2025
…rametersLoader) (powsybl#3360)

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
pjanecek0 pushed a commit to pjanecek0/powsybl-core that referenced this pull request Mar 14, 2025
…rametersLoader) (powsybl#3360)

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants