Skip to content

Restore missing constructor in LoadFlowParameters #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olperr1 merged 3 commits into from
Mar 14, 2025
Merged

Restore missing constructor in LoadFlowParameters #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c0cdd
Restore missing constructor LoadFlowParameters(List<LoadFlowDefaultPa…
olperr1 Mar 14, 2025
3e3ca2f
Merge branch 'main' into restore_missing_method_in_LoadFlowParameters
olperr1 Mar 14, 2025
f083593
Merge branch 'main' into restore_missing_method_in_LoadFlowParameters
olperr1 Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,11 @@ protected LoadFlowParameters(PlatformConfig config) {
.toList(), config);
}

protected LoadFlowParameters(List<LoadFlowDefaultParametersLoader> defaultParametersLoaders, PlatformConfig config) {
public LoadFlowParameters(List<LoadFlowDefaultParametersLoader> defaultParametersLoaders) {
this(defaultParametersLoaders, PlatformConfig.defaultConfig());
}

public LoadFlowParameters(List<LoadFlowDefaultParametersLoader> defaultParametersLoaders, PlatformConfig config) {
// Check default-parameters-loader config parameter
String selectedLoaderName;
Optional<LoadFlowDefaultParametersLoader> selectedLoader = Optional.empty();
Expand Down
3 changes: 1 addition & 2 deletions .../loadflow-api/src/test/java/com/powsybl/loadflow/LoadFlowDefaultParametersLoaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import com.powsybl.commons.PowsyblException;
import com.powsybl.commons.config.InMemoryPlatformConfig;
import com.powsybl.commons.config.MapModuleConfig;
import com.powsybl.commons.config.PlatformConfig;
import com.powsybl.commons.extensions.Extension;
import com.powsybl.loadflow.json.JsonLoadFlowParametersTest;
import org.junit.jupiter.api.BeforeEach;
Expand Down Expand Up @@ -74,7 +73,7 @@ void testCorrectLoadingOrder() {

LoadFlowDefaultParametersLoaderMock loader = new LoadFlowDefaultParametersLoaderMock("test");

LoadFlowParameters parameters = new LoadFlowParameters(List.of(loader), PlatformConfig.defaultConfig());
LoadFlowParameters parameters = new LoadFlowParameters(List.of(loader));
load(parameters, platformConfig);
assertFalse(parameters.isUseReactiveLimits());
assertEquals(LoadFlowParameters.VoltageInitMode.PREVIOUS_VALUES, parameters.getVoltageInitMode());
Expand Down