Skip to content

Conversation

@pp-mo
Copy link
Owner

@pp-mo pp-mo commented Mar 6, 2025

Closes #68
Closes #161
Closes #166

@pp-mo pp-mo marked this pull request as ready for review March 11, 2025 14:32
@trexfeathers trexfeathers marked this pull request as draft April 9, 2025 09:52
@pp-mo
Copy link
Owner Author

pp-mo commented Apr 9, 2025

Update:

Fixed variable comparison for newly-added "no-data" variable testcases
and added testing for the new usage.

Still WIP/TODO:

we now have the beginnings of a strategy to run a set of testcases through both the ncdata.utils.index_by_dimensions and the ncdata.utils.Slicer APIs.
So far we are testing the first of these but not the second.

@pp-mo pp-mo mentioned this pull request Apr 9, 2025
6 tasks
@pp-mo pp-mo linked an issue Apr 9, 2025 that may be closed by this pull request
@pp-mo
Copy link
Owner Author

pp-mo commented Sep 3, 2025

Update

Testing+ passing against various uses, in both 'index_by_dimension' and 'Slicer' forms
Todos

  • Whatsnew
  • Additional tests, e.g. Error modes
  • Add a Howto entry
  • ?? other docs mentions?

@pp-mo pp-mo marked this pull request as ready for review September 7, 2025 00:54
@pp-mo pp-mo force-pushed the dim_slicer branch 3 times, most recently from 670efa6 to d78a97b Compare September 7, 2025 01:35
@ukmo-ccbunney
Copy link

Hey @pp-mo.

So, the Slicer class and index_by_dimensions utils are very useful (I made some other comments on #162 regarding the Slicer).

I really like the functionality of being able to slice the whole dataset, not just the individual variables. 🚀
This feels very much like the Xarray Dataset.[i]sel behaviour which makes it so much easier to work with compared to the netcdf4 library!

One minor thing: Could the Slicer class have a nice __str__ method to give some indication of the underlying NcData object it is associated with? Useful for interactive REPL use cases where you might want to check which object the Slicer is wrapped around.

@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 24, 2025
@pp-mo
Copy link
Owner Author

pp-mo commented Oct 2, 2025

Status update

WIP : Adopting solutions (still working on), as agreed -- see #162 (comment)

@pp-mo
Copy link
Owner Author

pp-mo commented Oct 2, 2025

There's now a huge amount of stuff in here, as it acquired a few more-or-less related changes.
Hopefully all OK now.
Going to just merge, since other changes are waiting on it.

@pp-mo pp-mo merged commit d24e7b9 into main Oct 2, 2025
5 checks passed
@pp-mo pp-mo deleted the dim_slicer branch October 3, 2025 13:54
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement == and != for datasets and variables Add a page describing the utilities. Dimension slicing utility

3 participants