Fix game crashing when no displays are connected #6691
Merged
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susko3
force-pushed
the
fix-zero-displays-crashing-game
branch
from
d598d13 to
0429fe4
Compare
|
Sentry issue: OSU-119X |
|
Sentry issue: OSU-2P4Z |
Contributor
|
Is it an alternative to #6501? |
peppy
approved these changes
Jan 3, 2026
Member
|
@Susko3 have you tested this on linux? |
Member
Author
|
I've tested this only on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SDL reports no displays, this PR simply ignores it, keeping the
Displaysstale. Previously,Displayswould get set to an empty array, causing the next call ofPrimaryDisplayto crash the game.Note: it's possible to launch the game with zero displays. In that case, it'll just immediately crash, which is fine.