Replace /bin/bash by /usr/bin/env bash
#660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicky Mouha <[email protected]>
mkannwischer
requested changes
Nov 12, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thank you for pointing this out @nmouha!
Let's port the entire pq-code-package/mlkem-native#1297 in one go.
@nmouha, do you want to give that a go? Otherwise, maybe @willieyz can take over.
Contributor
|
Done in #690 |
Contributor
Author
|
Great! Thank you, @hanno-becker and @mkannwischer! I'm closing this PR as it's superseded by #690. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Similar patch for mlkem-native: pq-code-package/mlkem-native#1295
The mldsa-native package fails to build on NixOS, because NixOS does not provide
/bin/bashby default.On NixOS, the recommended approach is to use
/usr/bin/env bashbecause this makes it easier to install different versions ofbashon the same system. (By lettingPATHdecide which binary to execute.) Note that/usr/bin/env bashis also the recommended approach on MacOS to use a newerbashversion than the system-provided one.I see that
/usr/bin/env bashand/usr/bin/env python3are already used in 15 locations (see for example: proofs/cbmc/list_proofs.sh). Therefore, I'm proposing to replace the remaining instances of/bin/bashto/usr/bin/env bash. So, this change not only fixes builds on NixOS, but is also more consistent.