Add NixOS build+test to CI and fix bash invocations #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready for review, but should be merged AFTER #640, assuming CI passes for that. |
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Nicky Mouha <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
nixos_test
branch
from
528b083 to
ddf870b
Compare
mkannwischer
approved these changes
Nov 13, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
One /bin/bash (in z3_no_bv_extract) was missed. I took the liberty to resolve that.
LGTM now.
Thanks @hanno-becker and @nmouha!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/bin/bashby/usr/bin/env bashmlkem-native#1295/bin/bashby/usr/bin/env bash#660, to ensure full CI passes (does currently not work from a fork).