Namespace STACK_SIZE #1396
Draft
Namespace STACK_SIZE #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #define STACK_SIZE (16*6 + 8*8 + 6*8 + (STACK_LOCS) * 8) | ||
| #define MLK_STACK_SIZE (16*6 + 8*8 + 6*8 + (STACK_LOCS) * 8) | ||
| #define STACK_BASE_GPRS (6*8) |
Contributor
There was a problem hiding this comment.
We shouldn't namespace STACK_SIZE, but not the other macros; either all of them, or none.
hanno-becker
requested changes
Dec 17, 2025
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
If we do this we should namespace all macros in the assembly files.
Note that the lack of namespacing here is of little effect since all affected files are in dev/ and not in the main source tree.
willieyz
force-pushed
the
namespace-STACK_SIZE
branch
3 times, most recently
from
a7001df to
59a18fd
Compare
willieyz
force-pushed
the
namespace-STACK_SIZE
branch
2 times, most recently
from
e96e223 to
0878495
Compare
willieyz
force-pushed
the
namespace-STACK_SIZE
branch
4 times, most recently
from
f855045 to
b6a4787
Compare
willieyz
force-pushed
the
namespace-STACK_SIZE
branch
from
b6a4787 to
4db09cb
Compare
- The STACK_SIZE should namespace as MLK_STACK_SIZE to avoid clashing with symbols in consuming libraries. - Also, found a missing namespace macro called KECCAK_F1600_ROUNDS, also namespace it. - This commit also namespace rej_uniform_asm Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
namespace-STACK_SIZE
branch
from
4db09cb to
5f64f67
Compare
Signed-off-by: willieyz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Namespace
STACK_SIZEin various assembly files #1395The STACK_SIZE should namespace as MLK_STACK_SIZE to avoid clashing with symbols in consuming libraries.