Stop toggling lightline on setting contents of popup #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem is that when some exception was thrown while setting the filetype, lightline can't be enabled (itchyny/lightline.vim#409 (comment)). One solution is to wrap the |
itchyny
force-pushed
the
remove-lightline-toggle
branch
from
3b96fc8 to
605abdf
Compare
|
Yes of course, if lightline now is fixed now, just remove the code! (As it already was mentioned in the code comment :) ) |
mattn
requested review from
thomasfaingnaert and
mattn
and removed request for
thomasfaingnaert
mattn
approved these changes
Feb 19, 2020
|
Thanks all! |
kg8m
pushed a commit
to kg8m/vim-lsp
that referenced
this pull request
Feb 20, 2020
) Co-authored-by: mattn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure which situation these lines are required, but the code was introduced on June 26, 2019 (#395), and lightline fixes for popup on July 15, 2019 (itchyny/lightline.vim#371) so I believe these aren't required anymore.
Ping to @jerdna-regeiz.