Skip to content

Stop toggling lightline on setting contents of popup #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Stop toggling lightline on setting contents of popup #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
605abdf
Stop toggling lightline on setting contents of popup
itchyny Feb 17, 2020
31cbd45
Merge branch 'master' into remove-lightline-toggle
mattn Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions autoload/lsp/ui/vim/output.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,21 +149,10 @@ function! s:setcontent(lines, ft) abort
if s:use_vim_popup
" vim popup
call setbufline(winbufnr(s:winid), 1, a:lines)
let l:lightline_toggle = v:false
if exists('#lightline') && !has('nvim')
" Lightline does not work in popups but does not recognize it yet.
" It is ugly to have an check for an other plugin here, better fix lightline...
let l:lightline_toggle = v:true
call lightline#disable()
endif
call win_execute(s:winid, 'setlocal filetype=' . a:ft . '.lsp-hover')
if l:lightline_toggle
call lightline#enable()
endif
else
" nvim floating or preview
call setline(1, a:lines)

setlocal readonly nomodifiable
silent! let &l:filetype = a:ft . '.lsp-hover'
endif
Expand Down