fix(types): fix type inference issue of register method #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
approved these changes
Sep 8, 2025
|
I wish all my PRs would be merged so fast at work ^^ Thank you :D |
|
Lmao, I think we all would |
This was referenced Sep 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the declaration of
Componentas anAnyComponentwithpreact-custom-elementin version4.5.0the typescript compiler complains about not compatible types:This issue is caused because register function doesn’t define generic type parameters, so TypeScript doesn’t know how to infer P and S. By doing so TypeScript is happy again: