RhythmOne Adapter: dedupe frameImp and interpretResponse flows#14571
RhythmOne Adapter: dedupe frameImp and interpretResponse flows#14571patmmccann wants to merge 1 commit intomasterfrom
Conversation
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a4fd2760
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const impObj = { | ||
| id: bidRequestData.adUnitCode, | ||
| secure: isSecure, | ||
| ext: frameExt(bidRequestData) |
There was a problem hiding this comment.
Validate media before invoking frameExt
buildImpressionList now calls frameExt before verifying that a bid produced a valid banner/video impression, which changes behavior for malformed bids that should be skipped. In the Marsmedia path, frameExt performs banner-size processing (getMinSize(processedSizes)) and can throw on invalid mediaTypes.banner.sizes shapes; previously frameExt was only reached after frameBanner/frameVideo succeeded, so these bids were dropped instead of crashing request building. This can cause the adapter request flow to fail for bad publisher size configs that were previously tolerated.
Useful? React with 👍 / 👎.
Pull Request Test Coverage Report for Build 22873766541Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Motivation