-
Notifications
You must be signed in to change notification settings - Fork 2.3k
RhythmOne Adapter: dedupe frameImp and interpretResponse flows #14571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patmmccann
wants to merge
1
commit into
master
Choose a base branch
from
codex/extract-common-functions-into-library-sunlom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+234
−270
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| import { deepAccess, isArray, parseSizesInput } from '../../src/utils.js'; | ||
|
|
||
| export function getIsSecureBidRequest(bidderRequest) { | ||
| if (bidderRequest?.refererInfo?.stack?.length) { | ||
| const el = document.createElement('a'); | ||
| el.href = bidderRequest.refererInfo.stack[0]; | ||
| return (el.protocol === 'https:') ? 1 : 0; | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| export function buildImpressionList(bidRequests, bidderRequest, slotsToBids, options) { | ||
| const { frameExt, getFloor, defaultVideoConfig } = options; | ||
| const impList = []; | ||
| const isSecure = getIsSecureBidRequest(bidderRequest); | ||
|
|
||
| for (let i = 0; i < bidRequests.length; i++) { | ||
| const bidRequestData = bidRequests[i]; | ||
| slotsToBids[bidRequestData.adUnitCode] = bidRequestData; | ||
|
|
||
| const impObj = { | ||
| id: bidRequestData.adUnitCode, | ||
| secure: isSecure, | ||
| ext: frameExt(bidRequestData) | ||
| }; | ||
|
|
||
| if (deepAccess(bidRequestData, 'mediaTypes.banner') || deepAccess(bidRequestData, 'mediaType') === 'banner') { | ||
| const banner = frameBanner(bidRequestData); | ||
| if (banner) { | ||
| impObj.banner = banner; | ||
| } | ||
| } | ||
|
|
||
| if (deepAccess(bidRequestData, 'mediaTypes.video') || deepAccess(bidRequestData, 'mediaType') === 'video') { | ||
| impObj.video = frameVideo(bidRequestData, defaultVideoConfig); | ||
| } | ||
|
|
||
| if (!(impObj.banner || impObj.video)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (typeof getFloor === 'function') { | ||
| impObj.bidfloor = getFloor(bidRequestData); | ||
| } | ||
|
|
||
| impList.push(impObj); | ||
| } | ||
|
|
||
| return impList; | ||
| } | ||
|
|
||
| export function interpretCommonResponse(serverResponse, slotsToBids, options = {}) { | ||
| const { | ||
| baseBidResponse, | ||
| videoBidResponse, | ||
| bannerBidResponse | ||
| } = options; | ||
| let responses = serverResponse.body || []; | ||
| const bids = []; | ||
|
|
||
| if (responses.seatbid) { | ||
| const flattenedResponses = []; | ||
| for (let i = 0; i < responses.seatbid.length; i++) { | ||
| for (let j = 0; j < responses.seatbid[i].bid.length; j++) { | ||
| flattenedResponses.push(responses.seatbid[i].bid[j]); | ||
| } | ||
| } | ||
| responses = flattenedResponses; | ||
| } | ||
|
|
||
| for (let i = 0; i < responses.length; i++) { | ||
| const bid = responses[i]; | ||
| const bidRequest = slotsToBids[bid.impid]; | ||
| if (!bidRequest) { | ||
| continue; | ||
| } | ||
|
|
||
| const bidResponse = { | ||
| requestId: bidRequest.bidId, | ||
| cpm: parseFloat(bid.price), | ||
| width: bid.w, | ||
| height: bid.h, | ||
| creativeId: bid.crid, | ||
| currency: 'USD', | ||
| netRevenue: true, | ||
| ttl: 350 | ||
| }; | ||
|
|
||
| if (typeof baseBidResponse === 'function') { | ||
| Object.assign(bidResponse, baseBidResponse(bid, bidRequest)); | ||
| } | ||
|
|
||
| if (bidRequest.mediaTypes && bidRequest.mediaTypes.video) { | ||
| if (typeof videoBidResponse === 'function') { | ||
| Object.assign(bidResponse, videoBidResponse(bid, bidRequest)); | ||
| } | ||
| } else { | ||
| if (typeof bannerBidResponse === 'function') { | ||
| Object.assign(bidResponse, bannerBidResponse(bid, bidRequest)); | ||
| } | ||
| } | ||
|
|
||
| bids.push(bidResponse); | ||
| } | ||
|
|
||
| return bids; | ||
| } | ||
|
|
||
| export function frameBanner(adUnit) { | ||
| // adUnit.sizes is scheduled to be deprecated, continue its support but prefer adUnit.mediaTypes.banner | ||
| let sizeList = adUnit.sizes; | ||
| if (adUnit.mediaTypes && adUnit.mediaTypes.banner) { | ||
| sizeList = adUnit.mediaTypes.banner.sizes; | ||
| } | ||
|
|
||
| const sizeStringList = parseSizesInput(sizeList); | ||
| const format = []; | ||
| sizeStringList.forEach(function (size) { | ||
| if (size) { | ||
| const dimensionList = getValidSizeSet(size.split('x')); | ||
| if (dimensionList) { | ||
| format.push({ | ||
| w: dimensionList[0], | ||
| h: dimensionList[1], | ||
| }); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| return format.length ? { format } : false; | ||
| } | ||
|
|
||
| export function frameVideo(bid, defaultVideoConfig) { | ||
| let size = []; | ||
| if (deepAccess(bid, 'mediaTypes.video.playerSize')) { | ||
| let dimensionSet = bid.mediaTypes.video.playerSize; | ||
| if (isArray(bid.mediaTypes.video.playerSize[0])) { | ||
| dimensionSet = bid.mediaTypes.video.playerSize[0]; | ||
| } | ||
| const validSize = getValidSizeSet(dimensionSet) | ||
| if (validSize) { | ||
| size = validSize; | ||
| } | ||
| } | ||
| return { | ||
| mimes: deepAccess(bid, 'mediaTypes.video.mimes') || defaultVideoConfig.SUPPORTED_VIDEO_MIMES, | ||
| protocols: deepAccess(bid, 'mediaTypes.video.protocols') || defaultVideoConfig.SUPPORTED_VIDEO_PROTOCOLS, | ||
| w: size[0], | ||
| h: size[1], | ||
| startdelay: deepAccess(bid, 'mediaTypes.video.startdelay') || 0, | ||
| skip: deepAccess(bid, 'mediaTypes.video.skip') || 0, | ||
| playbackmethod: deepAccess(bid, 'mediaTypes.video.playbackmethod') || defaultVideoConfig.SUPPORTED_VIDEO_PLAYBACK_METHODS, | ||
| delivery: deepAccess(bid, 'mediaTypes.video.delivery') || defaultVideoConfig.SUPPORTED_VIDEO_DELIVERY, | ||
| api: deepAccess(bid, 'mediaTypes.video.api') || defaultVideoConfig.SUPPORTED_VIDEO_API, | ||
| } | ||
| } | ||
|
|
||
| function getValidSizeSet(dimensionList) { | ||
| const w = parseInt(dimensionList[0]); | ||
| const h = parseInt(dimensionList[1]); | ||
| // clever check for NaN | ||
| if (!(w !== w || h !== h)) { // eslint-disable-line | ||
| return [w, h]; | ||
| } | ||
| return false; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildImpressionListnow callsframeExtbefore verifying that a bid produced a valid banner/video impression, which changes behavior for malformed bids that should be skipped. In the Marsmedia path,frameExtperforms banner-size processing (getMinSize(processedSizes)) and can throw on invalidmediaTypes.banner.sizesshapes; previouslyframeExtwas only reached afterframeBanner/frameVideosucceeded, so these bids were dropped instead of crashing request building. This can cause the adapter request flow to fail for bad publisher size configs that were previously tolerated.Useful? React with 👍 / 👎.